Quantify issues

Recent GitHub Issues Activity

_{Like all software activity quantification, these numbers are imperfect but sometimes useful. Comments, Labels, and Milestones refer to those issues opened in the timespan in question.}

Rate pull requests

PR#10509 - New: Deprecate use of movie file tokens in Movie Folder Formatopen

2_/5

Bogdan (mynameisbogdan)Created: 2024-10-02

The pull request aims to deprecate movie file tokens in the Movie Folder Format, which is a significant change. However, it is still in draft status after 75 days and marked with 'Don't Merge', indicating incomplete work or unresolved issues. Additionally, the SonarCloud analysis shows a failure in the Quality Gate due to security hotspots and lack of test coverage (0.0%), which are critical concerns. The changes are not substantial enough to warrant a higher rating, especially given the security and testing deficiencies.

[+] Read More

PR#10537 - New: Lists retroactively apply tagsopen

2_/5

Steel City Phantom (scphantm)Created: 2024-10-07

The pull request introduces a feature to retroactively apply tags to existing movies, which is a useful addition. However, the implementation appears to be incomplete and possibly flawed, as indicated by the author's own comments about rethinking the solution and the presence of unnecessary fields. The PR also includes database migrations, which are significant changes, but the overall execution lacks clarity and thoroughness. Additionally, there are concerns about unit testing and documentation updates, which are crucial for a robust implementation. The review comments suggest that the changes should have been split into separate commits or PRs for better clarity and management. Therefore, this PR needs further refinement before it can be considered for merging.

[+] Read More

PR#10521 - Add Simkl to MovieDetailsLinks.tsxopen

2_/5

dingdong42564Created: 2024-10-07

The pull request adds a Simkl link to the movie details page, which is a minor UI enhancement. However, it lacks tests, translation keys, and wiki updates, indicating incomplete work. The PR has unresolved review comments about the link's placement and dependency on imdbid, suggesting poor implementation. The contributor is inexperienced with GitHub, as seen in their confusion about changing the base branch. Overall, the PR is notably flawed and incomplete.

[+] Read More

PR#10609 - RQBit support addedopen

2_/5

Mark Mendoza (markolo25)Created: 2024-10-27

The pull request introduces support for the RQBit torrent client, which is a significant addition. However, it is in draft state and lacks essential components such as tests and translation keys. The PR also has unresolved issues highlighted by the reviewer, including improper casing conventions, missing mandatory fields, and inefficient API usage. These issues indicate that the implementation is incomplete and requires substantial work before it can be considered for merging. Therefore, it is rated as 'Needs work'.

[+] Read More

PR#10656 - Update LoadingMessage.tsxopen

2_/5

TyzzyTCreated: 2024-11-08

The pull request adds a few humorous loading messages to the UI, which is a minor and non-essential change. It lacks tests, translation keys, and wiki updates, indicating incomplete work. The change is insignificant in terms of functionality or impact on the overall project. While it doesn't introduce any apparent bugs or security risks, its contribution is minimal and doesn't enhance the project's core features.

[+] Read More

PR#10730 - Pull Sonarr commit 'Use 'text-wrap: balance' for text wrapping on overview and details'open

2_/5

servarr[bot]Created: 2024-12-02

The pull request makes a minor change by adding 'text-wrap: balance' to two CSS classes, which is a small and relatively insignificant update. While it passes the quality gate with no new issues or security hotspots, the change itself is not substantial or impactful enough to warrant a higher rating. It addresses a specific issue but lacks broader significance or complexity.

[+] Read More

PR#10258 - New: Bump to .NET 8open

3_/5

Bogdan (mynameisbogdan)Created: 2024-08-02

This pull request involves a significant upgrade to .NET 8, which is a crucial update for the Radarr project. However, it also introduces breaking changes by dropping support for certain platforms, which could impact users negatively. The PR has been in draft for a long time, indicating potential issues or delays in finalizing the changes. While it includes necessary updates across multiple files and configurations, the overall impact is mixed due to the removal of platform support and the need for coordination with other projects before release. Thus, it is an average PR with both positive aspects and notable drawbacks.

[+] Read More

PR#10444 - New: Filters for TMDb Person listsopen

3_/5

Bogdan (mynameisbogdan)Created: 2024-09-16

The pull request introduces new filters for TMDb Person lists, which could be a useful feature addition. However, it lacks test coverage for the new code, as indicated by the 0.0% coverage on new code in SonarCloud analysis. This is a significant flaw as it may lead to undetected bugs or issues in the future. The changes are moderately significant but not exemplary due to the lack of thorough testing and potential integration issues, as suggested by the 'Don't Merge' label.

[+] Read More

PR#10517 - Added Original Title to Movie Details and to Add Movie Search Resultopen

3_/5

ManiMatterCreated: 2024-10-04

The pull request introduces a useful feature by adding the original title to movie details and search results, enhancing the user interface for multilingual users. However, it has faced significant pushback from a key reviewer due to concerns about UI consistency and potential user confusion. The PR includes some back-and-forth on implementation details and suggestions for improvement, indicating that while the feature is valuable, its current form may not be optimal. The changes are not groundbreaking but add moderate value, hence an average rating.

[+] Read More

PR#10573 - New: Parse JPN as Japanese and KOR as Koreanopen

4_/5

Bogdan (mynameisbogdan)Created: 2024-10-22

The pull request effectively addresses a specific issue by enhancing the language parsing capabilities of the codebase to include Japanese and Korean languages. The changes are well-contained, with modifications made to both the parser logic and corresponding test cases, ensuring robustness. The PR is significant as it fixes an open issue (#10044) and improves functionality. However, it is not exceptionally complex or groundbreaking, hence a rating of 4 is appropriate.

[+] Read More

Quantify commits

Quantified Commit Activity Over 14 Days

Developer	Avatar	Branches	PRs	Commits	Files	Changes
Weblate (bot)		1	0/0/0	2	11	554
Mark McDowall		1	0/0/0	5	10	213
Bogdan		1	0/1/0	12	26	187
Stevie Robinson		1	0/0/0	2	8	92
Servarr		1	3/5/0	2	1	81
None (cheese1)		0	1/0/1	0	0	0
soup (s0up4200)		0	1/1/0	0	0	0
None (sampulsar)		0	0/0/1	0	0	0
None (servarr[bot])		0	2/2/0	0	0	0
Alperen Kaplan (alperenkaplan)		0	1/0/1	0	0	0

_{PRs: created by that dev and opened/merged/closed-unmerged during the period}

Quantify risks

Project Risk Ratings

Report On: Fetch issues

Recent Activity Analysis

Recent GitHub issue activity for the Radarr project shows a consistent flow of new issues being created, with a mix of feature requests, bug reports, and pull requests. The issues are actively managed, with many being closed shortly after creation, indicating a responsive maintenance team.

A notable anomaly is the high number of conflicts in pull requests related to Sonarr commits (#10764, #10755, #10754). These conflicts suggest integration challenges between Radarr and Sonarr codebases, potentially due to differences in their respective repositories or recent changes that have not been synchronized.

Several issues highlight recurring themes such as language parsing (#10682), metadata handling (#10613), and download client integration (#10551). These indicate ongoing efforts to improve Radarr's core functionalities and user experience. The presence of multiple feature requests for enhanced filtering and sorting capabilities (#10571, #10469) suggests a demand for more granular control over movie management.

Issue Details

Most Recently Created Issues

• #10764: Pull Sonarr commit 'Convert Calendar to TypeScript'

  • Priority: High (due to conflicts)
  • Status: Open
  • Created: 2 days ago
  • Conflicts: 30

• #10755: Pull Sonarr commit 'Convert EpisodeHistory to TypeScript'

  • Priority: Medium
  • Status: Open
  • Created: 7 days ago
  • Conflicts: 8

• #10754: Pull Sonarr commit 'Convert EpisodeSearch to TypeScript'

  • Priority: Low
  • Status: Open
  • Created: 7 days ago
  • Conflicts: 1

Most Recently Updated Issues

• #10764: Pull Sonarr commit 'Convert Calendar to TypeScript'

  • Priority: High
  • Status: Open
  • Updated: Recently due to conflict resolution attempts

• #10755: Pull Sonarr commit 'Convert EpisodeHistory to TypeScript'

  • Priority: Medium
  • Status: Open
  • Updated: Recently due to conflict resolution attempts

Notable Closed Issues

• #10771: Pull Sonarr commit 'New: Series genres for search results'

  • Closed due to successful integration or resolution of conflicts.

• #10769: Pull Sonarr commit 'Fixed: Refresh backup list on deletion'

  • Closed after resolving the issue with no conflicts.

The active management of issues and the quick closure of resolved ones reflect a well-maintained project with a focus on continuous improvement and responsiveness to user feedback.

Report On: Fetch pull requests

Analysis of Pull Requests for Radarr/Radarr

Open Pull Requests

Notable Open PRs

1. PR #10258: New: Bump to .NET 8

   • State: Open
   • Created: 136 days ago
   • Draft: Yes
   • Labels: Area: UI, Area: API, Area: Db-migration
   • Milestone: v6.X
   • Comments: This PR involves a major version bump due to dropped platforms. It also requires coordination with another PR (#31) to prevent automatic updates between major versions.
   • Significance: This is a major update that will impact multiple areas of the project, including UI, API, and database migration. The long duration since creation suggests potential challenges or dependencies that need resolution.

2. PR #10609: RQBit support added

   • State: Open
   • Created: 50 days ago
   • Draft: Yes
   • Labels: Area: Download Clients, Status: Waiting for OP, Status: Don't Merge
   • Comments: The PR adds support for the RQBit torrent client but has several unresolved issues and feedback from reviewers indicating significant changes are needed.
   • Significance: This PR introduces new functionality but is currently stalled due to unresolved issues and feedback. It requires attention to move forward.

3. PR #10537: New: Lists retroactively apply tags

   • State: Open
   • Created: 70 days ago
   • Labels: Area: UI, Area: Import Lists, Status: Don't Merge, Area: Db-migration
   • Comments: This feature allows tags to be retroactively applied to existing movies in the database. The PR has undergone multiple revisions and discussions.
   • Significance: This feature could enhance the tagging system significantly but is currently marked as "Don't Merge," indicating it might not be ready for integration.

4. PR #10517: Added Original Title to Movie Details and to Add Movie Search Result

   • State: Open
   • Created: 73 days ago
   • Labels: Area: UI, Status: Don't Merge
   • Comments: The PR aims to display the original title alongside the translated title in movie details. There are ongoing discussions about UI changes.
   • Significance: This enhancement could improve user experience by providing more detailed information but faces challenges in terms of UI consistency across different screens.

General Observations on Open PRs

• Several open PRs are marked as "Don't Merge," indicating they are not ready for integration due to various reasons such as pending reviews, required changes, or dependencies on other work.
• Many open PRs involve significant changes or new features that require careful consideration and testing before merging.
• There is an emphasis on maintaining consistency with existing features and ensuring backward compatibility where possible.

Recently Closed Pull Requests

Notable Closed PRs

1. PR #10772: Translations update from Servarr Weblate

   • State: Closed (Merged)
   • Created/Closed: Same day
   • Significance: Regular updates to translations ensure that Radarr remains accessible to a global audience. These updates are crucial for maintaining internationalization support.

2. PR #10767 & #10770 (Sonarr Pulls)

   • Both were merged within a day of creation.
   • These pull requests indicate active synchronization with Sonarr's codebase, leveraging improvements and fixes made in Sonarr for Radarr's benefit.

3. PR #10725 & #10726

   • Addressed issues related to queue item properties and Transmission client labels respectively.
   • Both were closed quickly after creation, suggesting they were straightforward fixes or enhancements that did not require extensive review.

General Observations on Closed PRs

• Many closed PRs relate to synchronization with Sonarr or involve minor fixes and enhancements that can be quickly reviewed and integrated.
• The quick turnaround on some closed PRs indicates an efficient review process for certain types of changes, particularly those that are non-controversial or have been previously discussed.

Conclusion

The Radarr project is actively maintained with numerous open pull requests addressing significant updates and new features. However, some open PRs face challenges due to their complexity or dependencies on other work. Recently closed PRs show a mix of translation updates, synchronization with Sonarr improvements, and minor fixes—all contributing to the project's ongoing development and stability.

Report On: Fetch Files For Assessment

Source Code Assessment

File: src/NzbDrone.Core/Localization/Core/da.json

Analysis

• Purpose: This file contains Danish translations for the Radarr application, supporting localization efforts.
• Structure: The file is a JSON object with key-value pairs, where keys are identifiers used in the application and values are their Danish translations.
• Quality: The translations appear to be well-organized and consistent. There are no syntax errors or formatting issues visible in the provided excerpt.
• Localization Efforts: The presence of this file indicates active localization efforts, which is crucial for reaching a broader audience.

File: frontend/build/webpack.config.js

Analysis

• Purpose: This is a Webpack configuration file used to bundle the frontend assets of the Radarr application.
• Structure: The configuration is modular and well-structured, with clear separation of development and production settings.
• Quality:
  • Uses modern Webpack features like experiments for top-level await and optimization for deterministic module IDs.
  • Includes plugins for CSS extraction, HTML generation, and live reloading, indicating a comprehensive build setup.
  • The use of core-js versioning in Babel presets suggests attention to compatibility and polyfilling needs.
• Concerns: None apparent; the configuration is robust and follows best practices.

File: frontend/src/DiscoverMovie/Overview/DiscoverMovieOverview.css

Analysis

• Purpose: This CSS file styles the Discover Movie Overview component in the Radarr frontend.
• Structure: Utilizes CSS variables and mixins for styling consistency. Media queries are used for responsive design.
• Quality:
  • The use of composes indicates CSS Modules or similar technology, promoting modularity and scope isolation.
  • Styles are concise and likely effective for their purpose, though specific visual outcomes aren't assessable from code alone.
• Concerns: None apparent; the CSS is cleanly written.

File: src/NzbDrone.Core/Notifications/Telegram/Telegram.cs

Analysis

• Purpose: Implements Telegram notification functionality within Radarr's notification system.
• Structure:
  • Inherits from NotificationBase<TelegramSettings>, indicating adherence to a notification interface or base class pattern.
  • Methods handle various notification scenarios (e.g., movie added, download completed).
• Quality:
  • Code is clean and follows C# conventions. Use of dependency injection (ITelegramProxy, IConfigFileProvider) promotes testability and separation of concerns.
  • Error handling appears minimal; consider adding more robust exception management around network operations.
• Concerns: None critical; however, ensure all possible exceptions are handled when interacting with external services like Telegram.

File: src/NzbDrone.Core.Test/Download/Aggregation/Aggregators/AggregateLanguagesFixture.cs

Analysis

• Purpose: Contains unit tests for language aggregation logic in Radarr's download aggregation feature.
• Structure:
  • Uses NUnit framework with FluentAssertions for testing assertions.
  • Tests cover various scenarios involving language parsing and aggregation from release titles.
• Quality:
  • Tests are comprehensive and cover both positive and negative cases, ensuring robust validation of logic.
  • Mocking (Mock<IIndexerFactory>) is used effectively to isolate test cases from dependencies.
• Concerns: None; tests are well-written and maintainable.

File: frontend/src/Wanted/CutoffUnmet/CutoffUnmet.js

Analysis

• Purpose: React component managing the UI for movies that haven't met their quality cutoff in Radarr's Wanted section.
• Structure:
  • Lifecycle methods (componentDidUpdate) manage state updates based on prop changes.
  • Event handlers manage user interactions like filtering and toggling monitored status.
• Quality:
  • Code is structured following React best practices. State management is explicit, though consider using hooks if migrating to functional components in future updates.
  • PropTypes ensure type safety for component props, enhancing reliability during development.
• Concerns: None significant; consider performance optimizations if state or prop changes become complex.

File: src/NzbDrone.Core.Test/Datastore/Converters/TimeSpanConverterFixture.cs

Analysis

• Purpose: Unit tests for the TimeSpanConverter class responsible for converting TimeSpan objects to/from database representations.
• Structure:
  • Simple test cases verify conversion logic between TimeSpan objects and their string representations in a database context.
• Quality:
  • Tests are straightforward and validate essential functionality. Use of FluentAssertions enhances readability of assertions.
• Concerns: None; tests are appropriate for the converter's scope.

File: src/Radarr.Api.V3/openapi.json

Analysis

• Purpose: OpenAPI specification detailing the API endpoints available in Radarr's V3 API version.
• Structure:
  • Follows OpenAPI 3.0 standards with detailed path definitions, parameters, request bodies, and responses.
  • Includes server configurations and schema components for data models used across API endpoints.
• Quality:
  • Comprehensive documentation facilitates client generation and integration with tools like Swagger UI or Postman.
  • Consistent use of tags helps organize endpoints logically within API documentation tools.
• Concerns: Ensure ongoing synchronization between API implementation and this specification to prevent discrepancies.

File: src/NzbDrone.Common/Processes/ProcessProvider.cs

Analysis

• Purpose: Provides process management utilities within Radarr's common library, including starting processes, checking existence, and managing priorities.
• Structure:
  • Implements an interface (IProcessProvider) promoting flexibility through dependency injection or mocking in tests.
  • Methods cover a wide range of process-related operations, including error handling via logging mechanisms (NLog).
• Quality:
  • Code adheres to C# conventions with clear separation of concerns. Logging provides traceability for process operations.
  • Consider additional exception handling around process interactions to enhance robustness against system-level errors (e.g., access denied).
• Concerns: Minimal; ensure logging does not expose sensitive information when dealing with environment variables or command-line arguments.

File: azure-pipelines.yml

Analysis

• Purpose: Defines CI/CD pipeline configuration using Azure Pipelines for building, testing, packaging, and deploying Radarr across multiple platforms (Windows, Linux, macOS).
• Structure:
  • Utilizes multiple stages (Setup, Build_Backend, Build_Frontend) with jobs tailored to different OS environments using matrix strategies for parallel execution.
  • Includes caching strategies (Yarn packages), artifact publishing steps, and conditional task execution based on branch conditions or build results.
• Quality:
  • Comprehensive pipeline setup supports extensive testing across environments. Use of variables enhances maintainability by centralizing configuration values (e.g., versions).
  • Integration with Sentry for source map uploads demonstrates attention to post-deployment monitoring capabilities.
• Concerns: Ensure pipeline complexity remains manageable as new features or platforms are added. Regularly review pipeline efficiency to optimize build times.

Overall, the codebase demonstrates high quality across various components with attention to best practices in software engineering. Continued focus on testing coverage, error handling improvements, and documentation synchronization will further enhance reliability and maintainability.

Report On: Fetch commits

Development Team and Recent Activity

Team Members and Recent Contributions

1. Weblate (bot)

   • Commits: 2
   • Changes: 554 across 11 files
   • Branches: 1
   • Activity: Focused on updating translations across multiple languages.

2. Bogdan (mynameisbogdan)

   • Commits: 12
   • Changes: 187 across 26 files
   • Branches: 1
   • Activity: Worked on various features including improving the movie modal, updating TypeScript and core-js, fixing bugs related to movie genres and download clients, and version bumps.

3. Stevie Robinson (stevietv)

   • Commits: 2
   • Changes: 92 across 8 files
   • Branches: 1
   • Activity: Added new features like instance name in Telegram notifications and language support in webhook notifications.

4. Mark McDowall (markus101)

   • Commits: 5
   • Changes: 213 across 10 files
   • Branches: 1
   • Activity: Fixed various issues including augmenting languages from indexer, movies bypassing tags, and error handling in processes.

5. ServarrAdmin

   • Commits: 2
   • Changes: 81 across 1 file
   • Branches: 1
   • Activity: Automated API documentation updates.

6. Robin Dadswell (RobinDadswell)

   • No recent commits but previously fixed test issues and updated macOS image version.

7. Soup (s0up4200)

   • No recent commits but previously added a config file setting for CGNAT authentication bypass.

Patterns, Themes, and Conclusions

• The development team is actively maintaining the project with frequent updates and bug fixes.
• Translation updates are regularly made by Weblate, indicating a focus on internationalization.
• Bogdan is highly active with numerous commits focusing on both feature enhancements and bug fixes.
• Collaboration is evident as several commits are co-authored or involve cherry-picking from other contributors' work.
• There is a clear emphasis on improving user experience through UI enhancements and feature additions like tooltips for extra genres.
• The project follows a structured release cycle with regular version bumps to ensure stability and feature delivery.
• Automation plays a significant role in the project's maintenance, particularly in translation updates and API documentation.

Overall, the Radarr team demonstrates a strong commitment to continuous improvement, user experience enhancement, and internationalization support.